'use strict';
const {disableInputAttributeSyncing} = require('shared/ReactFeatureFlags');
function emptyFunction() {}
describe('ReactDOMInput', () => {
let React;
let ReactDOM;
let ReactDOMServer;
let setUntrackedValue;
let setUntrackedChecked;
let container;
function dispatchEventOnNode(node, type) {
node.dispatchEvent(new Event(type, {bubbles: true, cancelable: true}));
}
beforeEach(() => {
jest.resetModules();
setUntrackedValue = Object.getOwnPropertyDescriptor(
HTMLInputElement.prototype,
'value',
).set;
setUntrackedChecked = Object.getOwnPropertyDescriptor(
HTMLInputElement.prototype,
'checked',
).set;
React = require('react');
ReactDOM = require('react-dom');
ReactDOMServer = require('react-dom/server');
container = document.createElement('div');
document.body.appendChild(container);
});
afterEach(() => {
document.body.removeChild(container);
jest.restoreAllMocks();
});
it('should warn for controlled value of 0 with missing onChange', () => {
expect(() => {
ReactDOM.render(<input type="text" value={0} />, container);
}).toErrorDev(
'Warning: You provided a `value` prop to a form field without an `onChange` handler.',
);
});
it('should warn for controlled value of "" with missing onChange', () => {
expect(() => {
ReactDOM.render(<input type="text" value="" />, container);
}).toErrorDev(
'Warning: You provided a `value` prop to a form field without an `onChange` handler.',
);
});
it('should warn for controlled value of "0" with missing onChange', () => {
expect(() => {
ReactDOM.render(<input type="text" value="0" />, container);
}).toErrorDev(
'Warning: You provided a `value` prop to a form field without an `onChange` handler.',
);
});
it('should warn for controlled value of false with missing onChange', () => {
expect(() =>
ReactDOM.render(<input type="checkbox" checked={false} />, container),
).toErrorDev(
'Warning: You provided a `checked` prop to a form field without an `onChange` handler.',
);
});
it('should warn with checked and no onChange handler with readOnly specified', () => {
ReactDOM.render(
<input type="checkbox" checked={false} readOnly={true} />,
container,
);
ReactDOM.unmountComponentAtNode(container);
expect(() =>
ReactDOM.render(
<input type="checkbox" checked={false} readOnly={false} />,
container,
),
).toErrorDev(
'Warning: You provided a `checked` prop to a form field without an `onChange` handler. ' +
'This will render a read-only field. If the field should be mutable use `defaultChecked`. ' +
'Otherwise, set either `onChange` or `readOnly`.',
);
});
it('should not warn about missing onChange in uncontrolled inputs', () => {
ReactDOM.render(<input />, container);
ReactDOM.unmountComponentAtNode(container);
ReactDOM.render(<input value={undefined} />, container);
ReactDOM.unmountComponentAtNode(container);
ReactDOM.render(<input type="text" />, container);
ReactDOM.unmountComponentAtNode(container);
ReactDOM.render(<input type="text" value={undefined} />, container);
ReactDOM.unmountComponentAtNode(container);
ReactDOM.render(<input type="checkbox" />, container);
ReactDOM.unmountComponentAtNode(container);
ReactDOM.render(<input type="checkbox" checked={undefined} />, container);
});
it('should not warn with value and onInput handler', () => {
ReactDOM.render(<input value="..." onInput={() => {}} />, container);
});
it('should properly control a value even if no event listener exists', () => {
let node;
expect(() => {
node = ReactDOM.render(<input type="text" value="lion" />, container);
}).toErrorDev(
'Warning: You provided a `value` prop to a form field without an `onChange` handler.',
);
setUntrackedValue.call(node, 'giraffe');
dispatchEventOnNode(node, 'input');
expect(node.value).toBe('lion');
});
it('should control a value in reentrant events', () => {
class ControlledInputs extends React.Component {
state = {value: 'lion'};
a = null;
b = null;
switchedFocus = false;
change(newValue) {
this.setState({value: newValue});
dispatchEventOnNode(this.a, 'input');
this.b.focus();
}
blur(currentValue) {
this.switchedFocus = true;
this.setState({value: currentValue});
}
render() {
return (
<div>
<input
type="text"
ref={n => (this.a = n)}
value={this.state.value}
onChange={e => this.change(e.target.value)}
onBlur={e => this.blur(e.target.value)}
/>
<input type="text" ref={n => (this.b = n)} />
</div>
);
}
}
const instance = ReactDOM.render(<ControlledInputs />, container);
instance.a.focus();
setUntrackedValue.call(instance.a, 'giraffe');
dispatchEventOnNode(instance.a, 'input');
dispatchEventOnNode(instance.a, 'blur');
dispatchEventOnNode(instance.a, 'focusout');
expect(instance.a.value).toBe('giraffe');
expect(instance.switchedFocus).toBe(true);
});
it('should control values in reentrant events with different targets', () => {
class ControlledInputs extends React.Component {
state = {value: 'lion'};
a = null;
b = null;
change(newValue) {
this.b.click();
}
render() {
return (
<div>
<input
type="text"
ref={n => (this.a = n)}
value="lion"
onChange={e => this.change(e.target.value)}
/>
<input
type="checkbox"
ref={n => (this.b = n)}
checked={true}
onChange={() => {}}
/>
</div>
);
}
}
const instance = ReactDOM.render(<ControlledInputs />, container);
setUntrackedValue.call(instance.a, 'giraffe');
dispatchEventOnNode(instance.a, 'input');
expect(instance.a.value).toBe('lion');
expect(instance.b.checked).toBe(true);
});
describe('switching text inputs between numeric and string numbers', () => {
it('does change the number 2 to "2.0" with no change handler', () => {
const stub = <input type="text" value={2} onChange={jest.fn()} />;
const node = ReactDOM.render(stub, container);
setUntrackedValue.call(node, '2.0');
dispatchEventOnNode(node, 'input');
expect(node.value).toBe('2');
if (disableInputAttributeSyncing) {
expect(node.hasAttribute('value')).toBe(false);
} else {
expect(node.getAttribute('value')).toBe('2');
}
});
it('does change the string "2" to "2.0" with no change handler', () => {
const stub = <input type="text" value={'2'} onChange={jest.fn()} />;
const node = ReactDOM.render(stub, container);
setUntrackedValue.call(node, '2.0');
dispatchEventOnNode(node, 'input');
expect(node.value).toBe('2');
if (disableInputAttributeSyncing) {
expect(node.hasAttribute('value')).toBe(false);
} else {
expect(node.getAttribute('value')).toBe('2');
}
});
it('changes the number 2 to "2.0" using a change handler', () => {
class Stub extends React.Component {
state = {
value: 2,
};
onChange = event => {
this.setState({value: event.target.value});
};
render() {
const {value} = this.state;
return <input type="text" value={value} onChange={this.onChange} />;
}
}
const stub = ReactDOM.render(<Stub />, container);
const node = ReactDOM.findDOMNode(stub);
setUntrackedValue.call(node, '2.0');
dispatchEventOnNode(node, 'input');
expect(node.value).toBe('2.0');
if (disableInputAttributeSyncing) {
expect(node.hasAttribute('value')).toBe(false);
} else {
expect(node.getAttribute('value')).toBe('2.0');
}
});
});
it('does change the string ".98" to "0.98" with no change handler', () => {
class Stub extends React.Component {
state = {
value: '.98',
};
render() {
return <input type="number" value={this.state.value} />;
}
}
let stub;
expect(() => {
stub = ReactDOM.render(<Stub />, container);
}).toErrorDev(
'You provided a `value` prop to a form field ' +
'without an `onChange` handler.',
);
const node = ReactDOM.findDOMNode(stub);
stub.setState({value: '0.98'});
expect(node.value).toEqual('0.98');
});
it('performs a state change from "" to 0', () => {
class Stub extends React.Component {
state = {
value: '',
};
render() {
return <input type="number" value={this.state.value} readOnly={true} />;
}
}
const stub = ReactDOM.render(<Stub />, container);
const node = ReactDOM.findDOMNode(stub);
stub.setState({value: 0});
expect(node.value).toEqual('0');
});
it('updates the value on radio buttons from "" to 0', function () {
ReactDOM.render(
<input type="radio" value="" onChange={function () {}} />,
container,
);
ReactDOM.render(
<input type="radio" value={0} onChange={function () {}} />,
container,
);
expect(container.firstChild.value).toBe('0');
expect(container.firstChild.getAttribute('value')).toBe('0');
});
it('updates the value on checkboxes from "" to 0', function () {
ReactDOM.render(
<input type="checkbox" value="" onChange={function () {}} />,
container,
);
ReactDOM.render(
<input type="checkbox" value={0} onChange={function () {}} />,
container,
);
expect(container.firstChild.value).toBe('0');
expect(container.firstChild.getAttribute('value')).toBe('0');
});
it('distinguishes precision for extra zeroes in string number values', () => {
class Stub extends React.Component {
state = {
value: '3.0000',
};
render() {
return <input type="number" value={this.state.value} />;
}
}
let stub;
expect(() => {
stub = ReactDOM.render(<Stub />, container);
}).toErrorDev(
'You provided a `value` prop to a form field ' +
'without an `onChange` handler.',
);
const node = ReactDOM.findDOMNode(stub);
stub.setState({value: '3'});
expect(node.value).toEqual('3');
});
it('should display `defaultValue` of number 0', () => {
const stub = <input type="text" defaultValue={0} />;
const node = ReactDOM.render(stub, container);
expect(node.getAttribute('value')).toBe('0');
expect(node.value).toBe('0');
});
it('only assigns defaultValue if it changes', () => {
class Test extends React.Component {
render() {
return <input defaultValue="0" />;
}
}
const component = ReactDOM.render(<Test />, container);
const node = ReactDOM.findDOMNode(component);
Object.defineProperty(node, 'defaultValue', {
get() {
return '0';
},
set(value) {
throw new Error(
`defaultValue was assigned ${value}, but it did not change!`,
);
},
});
component.forceUpdate();
});
it('should display "true" for `defaultValue` of `true`', () => {
const stub = <input type="text" defaultValue={true} />;
const node = ReactDOM.render(stub, container);
expect(node.value).toBe('true');
});
it('should display "false" for `defaultValue` of `false`', () => {
const stub = <input type="text" defaultValue={false} />;
const node = ReactDOM.render(stub, container);
expect(node.value).toBe('false');
});
it('should update `defaultValue` for uncontrolled input', () => {
const node = ReactDOM.render(
<input type="text" defaultValue="0" />,
container,
);
expect(node.value).toBe('0');
expect(node.defaultValue).toBe('0');
ReactDOM.render(<input type="text" defaultValue="1" />, container);
if (disableInputAttributeSyncing) {
expect(node.value).toBe('1');
expect(node.defaultValue).toBe('1');
} else {
expect(node.value).toBe('0');
expect(node.defaultValue).toBe('1');
}
});
it('should update `defaultValue` for uncontrolled date/time input', () => {
const node = ReactDOM.render(
<input type="date" defaultValue="1980-01-01" />,
container,
);
expect(node.value).toBe('1980-01-01');
expect(node.defaultValue).toBe('1980-01-01');
ReactDOM.render(<input type="date" defaultValue="2000-01-01" />, container);
if (disableInputAttributeSyncing) {
expect(node.value).toBe('2000-01-01');
expect(node.defaultValue).toBe('2000-01-01');
} else {
expect(node.value).toBe('1980-01-01');
expect(node.defaultValue).toBe('2000-01-01');
}
ReactDOM.render(<input type="date" />, container);
});
it('should take `defaultValue` when changing to uncontrolled input', () => {
const node = ReactDOM.render(
<input type="text" value="0" readOnly={true} />,
container,
);
expect(node.value).toBe('0');
expect(() =>
ReactDOM.render(<input type="text" defaultValue="1" />, container),
).toErrorDev(
'A component is changing a controlled input to be uncontrolled.',
);
expect(node.value).toBe('0');
});
it('should render defaultValue for SSR', () => {
const markup = ReactDOMServer.renderToString(
<input type="text" defaultValue="1" />,
);
const div = document.createElement('div');
div.innerHTML = markup;
expect(div.firstChild.getAttribute('value')).toBe('1');
expect(div.firstChild.getAttribute('defaultValue')).toBe(null);
});
it('should render value for SSR', () => {
const element = <input type="text" value="1" onChange={() => {}} />;
const markup = ReactDOMServer.renderToString(element);
const div = document.createElement('div');
div.innerHTML = markup;
expect(div.firstChild.getAttribute('value')).toBe('1');
expect(div.firstChild.getAttribute('defaultValue')).toBe(null);
});
it('should render name attribute if it is supplied', () => {
const node = ReactDOM.render(<input type="text" name="name" />, container);
expect(node.name).toBe('name');
expect(container.firstChild.getAttribute('name')).toBe('name');
});
it('should render name attribute if it is supplied for SSR', () => {
const element = <input type="text" name="name" />;
const markup = ReactDOMServer.renderToString(element);
const div = document.createElement('div');
div.innerHTML = markup;
expect(div.firstChild.getAttribute('name')).toBe('name');
});
it('should not render name attribute if it is not supplied', () => {
ReactDOM.render(<input type="text" />, container);
expect(container.firstChild.getAttribute('name')).toBe(null);
});
it('should not render name attribute if it is not supplied for SSR', () => {
const element = <input type="text" />;
const markup = ReactDOMServer.renderToString(element);
const div = document.createElement('div');
div.innerHTML = markup;
expect(div.firstChild.getAttribute('name')).toBe(null);
});
it('should display "foobar" for `defaultValue` of `objToString`', () => {
const objToString = {
toString: function () {
return 'foobar';
},
};
const stub = <input type="text" defaultValue={objToString} />;
const node = ReactDOM.render(stub, container);
expect(node.value).toBe('foobar');
});
it('should throw for date inputs if `defaultValue` is an object where valueOf() throws', () => {
class TemporalLike {
valueOf() {
throw new TypeError('prod message');
}
toString() {
return '2020-01-01';
}
}
const test = () =>
ReactDOM.render(
<input defaultValue={new TemporalLike()} type="date" />,
container,
);
expect(() =>
expect(test).toThrowError(new TypeError('prod message')),
).toErrorDev(
'Form field values (value, checked, defaultValue, or defaultChecked props) must be ' +
'strings, not TemporalLike. This value must be coerced to a string before before using it here.',
);
});
it('should throw for text inputs if `defaultValue` is an object where valueOf() throws', () => {
class TemporalLike {
valueOf() {
throw new TypeError('prod message');
}
toString() {
return '2020-01-01';
}
}
const test = () =>
ReactDOM.render(
<input defaultValue={new TemporalLike()} type="text" />,
container,
);
expect(() =>
expect(test).toThrowError(new TypeError('prod message')),
).toErrorDev(
'Form field values (value, checked, defaultValue, or defaultChecked props) must be ' +
'strings, not TemporalLike. This value must be coerced to a string before before using it here.',
);
});
it('should throw for date inputs if `value` is an object where valueOf() throws', () => {
class TemporalLike {
valueOf() {
throw new TypeError('prod message');
}
toString() {
return '2020-01-01';
}
}
const test = () =>
ReactDOM.render(
<input value={new TemporalLike()} type="date" onChange={() => {}} />,
container,
);
expect(() =>
expect(test).toThrowError(new TypeError('prod message')),
).toErrorDev(
'Form field values (value, checked, defaultValue, or defaultChecked props) must be ' +
'strings, not TemporalLike. This value must be coerced to a string before before using it here.',
);
});
it('should throw for text inputs if `value` is an object where valueOf() throws', () => {
class TemporalLike {
valueOf() {
throw new TypeError('prod message');
}
toString() {
return '2020-01-01';
}
}
const test = () =>
ReactDOM.render(
<input value={new TemporalLike()} type="text" onChange={() => {}} />,
container,
);
expect(() =>
expect(test).toThrowError(new TypeError('prod message')),
).toErrorDev(
'Form field values (value, checked, defaultValue, or defaultChecked props) must be ' +
'strings, not TemporalLike. This value must be coerced to a string before before using it here.',
);
});
it('should display `value` of number 0', () => {
const stub = <input type="text" value={0} onChange={emptyFunction} />;
const node = ReactDOM.render(stub, container);
expect(node.value).toBe('0');
});
it('should allow setting `value` to `true`', () => {
let stub = <input type="text" value="yolo" onChange={emptyFunction} />;
const node = ReactDOM.render(stub, container);
expect(node.value).toBe('yolo');
stub = ReactDOM.render(
<input type="text" value={true} onChange={emptyFunction} />,
container,
);
expect(node.value).toEqual('true');
});
it('should allow setting `value` to `false`', () => {
let stub = <input type="text" value="yolo" onChange={emptyFunction} />;
const node = ReactDOM.render(stub, container);
expect(node.value).toBe('yolo');
stub = ReactDOM.render(
<input type="text" value={false} onChange={emptyFunction} />,
container,
);
expect(node.value).toEqual('false');
});
it('should allow setting `value` to `objToString`', () => {
let stub = <input type="text" value="foo" onChange={emptyFunction} />;
const node = ReactDOM.render(stub, container);
expect(node.value).toBe('foo');
const objToString = {
toString: function () {
return 'foobar';
},
};
stub = ReactDOM.render(
<input type="text" value={objToString} onChange={emptyFunction} />,
container,
);
expect(node.value).toEqual('foobar');
});
it('should not incur unnecessary DOM mutations', () => {
ReactDOM.render(<input value="a" onChange={() => {}} />, container);
const node = container.firstChild;
let nodeValue = 'a';
const nodeValueSetter = jest.fn();
Object.defineProperty(node, 'value', {
get: function () {
return nodeValue;
},
set: nodeValueSetter.mockImplementation(function (newValue) {
nodeValue = newValue;
}),
});
ReactDOM.render(<input value="a" onChange={() => {}} />, container);
expect(nodeValueSetter).toHaveBeenCalledTimes(0);
ReactDOM.render(<input value="b" onChange={() => {}} />, container);
expect(nodeValueSetter).toHaveBeenCalledTimes(1);
});
it('should not incur unnecessary DOM mutations for numeric type conversion', () => {
ReactDOM.render(<input value="0" onChange={() => {}} />, container);
const node = container.firstChild;
let nodeValue = '0';
const nodeValueSetter = jest.fn();
Object.defineProperty(node, 'value', {
get: function () {
return nodeValue;
},
set: nodeValueSetter.mockImplementation(function (newValue) {
nodeValue = newValue;
}),
});
ReactDOM.render(<input value={0} onChange={() => {}} />, container);
expect(nodeValueSetter).toHaveBeenCalledTimes(0);
});
it('should not incur unnecessary DOM mutations for the boolean type conversion', () => {
ReactDOM.render(<input value="true" onChange={() => {}} />, container);
const node = container.firstChild;
let nodeValue = 'true';
const nodeValueSetter = jest.fn();
Object.defineProperty(node, 'value', {
get: function () {
return nodeValue;
},
set: nodeValueSetter.mockImplementation(function (newValue) {
nodeValue = newValue;
}),
});
ReactDOM.render(<input value={true} onChange={() => {}} />, container);
expect(nodeValueSetter).toHaveBeenCalledTimes(0);
});
it('should properly control a value of number `0`', () => {
const stub = <input type="text" value={0} onChange={emptyFunction} />;
const node = ReactDOM.render(stub, container);
setUntrackedValue.call(node, 'giraffe');
dispatchEventOnNode(node, 'input');
expect(node.value).toBe('0');
});
it('should properly control 0.0 for a text input', () => {
const stub = <input type="text" value={0} onChange={emptyFunction} />;
const node = ReactDOM.render(stub, container);
setUntrackedValue.call(node, '0.0');
dispatchEventOnNode(node, 'input');
expect(node.value).toBe('0');
});
it('should properly control 0.0 for a number input', () => {
const stub = <input type="number" value={0} onChange={emptyFunction} />;
const node = ReactDOM.render(stub, container);
setUntrackedValue.call(node, '0.0');
dispatchEventOnNode(node, 'input');
if (disableInputAttributeSyncing) {
expect(node.value).toBe('0.0');
expect(node.hasAttribute('value')).toBe(false);
} else {
dispatchEventOnNode(node, 'blur');
dispatchEventOnNode(node, 'focusout');
expect(node.value).toBe('0.0');
expect(node.getAttribute('value')).toBe('0.0');
}
});
it('should properly transition from an empty value to 0', function () {
ReactDOM.render(
<input type="text" value="" onChange={emptyFunction} />,
container,
);
ReactDOM.render(
<input type="text" value={0} onChange={emptyFunction} />,
container,
);
const node = container.firstChild;
expect(node.value).toBe('0');
if (disableInputAttributeSyncing) {
expect(node.hasAttribute('value')).toBe(false);
} else {
expect(node.defaultValue).toBe('0');
}
});
it('should properly transition from 0 to an empty value', function () {
ReactDOM.render(
<input type="text" value={0} onChange={emptyFunction} />,
container,
);
ReactDOM.render(
<input type="text" value="" onChange={emptyFunction} />,
container,
);
const node = container.firstChild;
expect(node.value).toBe('');
expect(node.defaultValue).toBe('');
});
it('should properly transition a text input from 0 to an empty 0.0', function () {
ReactDOM.render(
<input type="text" value={0} onChange={emptyFunction} />,
container,
);
ReactDOM.render(
<input type="text" value="0.0" onChange={emptyFunction} />,
container,
);
const node = container.firstChild;
expect(node.value).toBe('0.0');
if (disableInputAttributeSyncing) {
expect(node.hasAttribute('value')).toBe(false);
} else {
expect(node.defaultValue).toBe('0.0');
}
});
it('should properly transition a number input from "" to 0', function () {
ReactDOM.render(
<input type="number" value="" onChange={emptyFunction} />,
container,
);
ReactDOM.render(
<input type="number" value={0} onChange={emptyFunction} />,
container,
);
const node = container.firstChild;
expect(node.value).toBe('0');
if (disableInputAttributeSyncing) {
expect(node.hasAttribute('value')).toBe(false);
} else {
expect(node.defaultValue).toBe('0');
}
});
it('should properly transition a number input from "" to "0"', function () {
ReactDOM.render(
<input type="number" value="" onChange={emptyFunction} />,
container,
);
ReactDOM.render(
<input type="number" value="0" onChange={emptyFunction} />,
container,
);
const node = container.firstChild;
expect(node.value).toBe('0');
if (disableInputAttributeSyncing) {
expect(node.hasAttribute('value')).toBe(false);
} else {
expect(node.defaultValue).toBe('0');
}
});
it('should have the correct target value', () => {
let handled = false;
const handler = function (event) {
expect(event.target.nodeName).toBe('INPUT');
handled = true;
};
const stub = <input type="text" value={0} onChange={handler} />;
const node = ReactDOM.render(stub, container);
setUntrackedValue.call(node, 'giraffe');
dispatchEventOnNode(node, 'input');
expect(handled).toBe(true);
});
it('should restore uncontrolled inputs to last defaultValue upon reset', () => {
const inputRef = React.createRef();
ReactDOM.render(
<form>
<input defaultValue="default1" ref={inputRef} />
<input type="reset" />
</form>,
container,
);
expect(inputRef.current.value).toBe('default1');
setUntrackedValue.call(inputRef.current, 'changed');
dispatchEventOnNode(inputRef.current, 'input');
expect(inputRef.current.value).toBe('changed');
ReactDOM.render(
<form>
<input defaultValue="default2" ref={inputRef} />
<input type="reset" />
</form>,
container,
);
expect(inputRef.current.value).toBe('changed');
container.firstChild.reset();
expect(inputRef.current.value).toBe('default2');
});
it('should not set a value for submit buttons unnecessarily', () => {
const stub = <input type="submit" />;
ReactDOM.render(stub, container);
const node = container.firstChild;
expect(node.hasAttribute('value')).toBe(false);
});
it('should remove the value attribute on submit inputs when value is updated to undefined', () => {
const stub = <input type="submit" value="foo" onChange={emptyFunction} />;
ReactDOM.render(stub, container);
expect(() =>
ReactDOM.render(
<input type="submit" value={undefined} onChange={emptyFunction} />,
container,
),
).toErrorDev(
'A component is changing a controlled input to be uncontrolled.',
);
const node = container.firstChild;
expect(node.getAttribute('value')).toBe(null);
});
it('should remove the value attribute on reset inputs when value is updated to undefined', () => {
const stub = <input type="reset" value="foo" onChange={emptyFunction} />;
ReactDOM.render(stub, container);
expect(() =>
ReactDOM.render(
<input type="reset" value={undefined} onChange={emptyFunction} />,
container,
),
).toErrorDev(
'A component is changing a controlled input to be uncontrolled.',
);
const node = container.firstChild;
expect(node.getAttribute('value')).toBe(null);
});
it('should set a value on a submit input', () => {
const stub = <input type="submit" value="banana" />;
ReactDOM.render(stub, container);
const node = container.firstChild;
expect(node.getAttribute('value')).toBe('banana');
});
it('should not set an undefined value on a submit input', () => {
const stub = <input type="submit" value={undefined} />;
ReactDOM.render(stub, container);
const node = container.firstChild;
expect(node.getAttribute('value')).toBe(null);
ReactDOM.render(stub, container);
expect(node.getAttribute('value')).toBe(null);
});
it('should not set an undefined value on a reset input', () => {
const stub = <input type="reset" value={undefined} />;
ReactDOM.render(stub, container);
const node = container.firstChild;
expect(node.getAttribute('value')).toBe(null);
ReactDOM.render(stub, container);
expect(node.getAttribute('value')).toBe(null);
});
it('should not set a null value on a submit input', () => {
const stub = <input type="submit" value={null} />;
expect(() => {
ReactDOM.render(stub, container);
}).toErrorDev('`value` prop on `input` should not be null');
const node = container.firstChild;
expect(node.getAttribute('value')).toBe(null);
ReactDOM.render(stub, container);
expect(node.getAttribute('value')).toBe(null);
});
it('should not set a null value on a reset input', () => {
const stub = <input type="reset" value={null} />;
expect(() => {
ReactDOM.render(stub, container);
}).toErrorDev('`value` prop on `input` should not be null');
const node = container.firstChild;
expect(node.getAttribute('value')).toBe(null);
ReactDOM.render(stub, container);
expect(node.getAttribute('value')).toBe(null);
});
it('should set a value on a reset input', () => {
const stub = <input type="reset" value="banana" />;
ReactDOM.render(stub, container);
const node = container.firstChild;
expect(node.getAttribute('value')).toBe('banana');
});
it('should set an empty string value on a submit input', () => {
const stub = <input type="submit" value="" />;
ReactDOM.render(stub, container);
const node = container.firstChild;
expect(node.getAttribute('value')).toBe('');
});
it('should set an empty string value on a reset input', () => {
const stub = <input type="reset" value="" />;
ReactDOM.render(stub, container);
const node = container.firstChild;
expect(node.getAttribute('value')).toBe('');
});
it('should control radio buttons', () => {
class RadioGroup extends React.Component {
aRef = React.createRef();
bRef = React.createRef();
cRef = React.createRef();
render() {
return (
<div>
<input
ref={this.aRef}
type="radio"
name="fruit"
checked={true}
onChange={emptyFunction}
/>
A
<input
ref={this.bRef}
type="radio"
name="fruit"
onChange={emptyFunction}
/>
B
<form>
<input
ref={this.cRef}
type="radio"
name="fruit"
defaultChecked={true}
onChange={emptyFunction}
/>
</form>
</div>
);
}
}
const stub = ReactDOM.render(<RadioGroup />, container);
const aNode = stub.aRef.current;
const bNode = stub.bRef.current;
const cNode = stub.cRef.current;
expect(aNode.checked).toBe(true);
expect(bNode.checked).toBe(false);
expect(cNode.checked).toBe(true);
if (disableInputAttributeSyncing) {
expect(aNode.hasAttribute('checked')).toBe(false);
expect(bNode.hasAttribute('checked')).toBe(false);
expect(cNode.hasAttribute('checked')).toBe(true);
} else {
expect(aNode.hasAttribute('checked')).toBe(true);
expect(bNode.hasAttribute('checked')).toBe(false);
expect(cNode.hasAttribute('checked')).toBe(true);
}
setUntrackedChecked.call(bNode, true);
expect(aNode.checked).toBe(false);
expect(cNode.checked).toBe(true);
if (disableInputAttributeSyncing) {
expect(aNode.hasAttribute('checked')).toBe(false);
expect(bNode.hasAttribute('checked')).toBe(false);
expect(cNode.hasAttribute('checked')).toBe(true);
} else {
expect(aNode.hasAttribute('checked')).toBe(true);
expect(bNode.hasAttribute('checked')).toBe(false);
expect(cNode.hasAttribute('checked')).toBe(true);
}
dispatchEventOnNode(bNode, 'click');
expect(aNode.checked).toBe(true);
expect(cNode.checked).toBe(true);
});
it('should check the correct radio when the selected name moves', () => {
class App extends React.Component {
state = {
updated: false,
};
onClick = () => {
this.setState({updated: true});
};
render() {
const {updated} = this.state;
const radioName = updated ? 'secondName' : 'firstName';
return (
<div>
<button type="button" onClick={this.onClick} />
<input
type="radio"
name={radioName}
onChange={emptyFunction}
checked={updated === true}
/>
<input
type="radio"
name={radioName}
onChange={emptyFunction}
checked={updated === false}
/>
</div>
);
}
}
const stub = ReactDOM.render(<App />, container);
const buttonNode = ReactDOM.findDOMNode(stub).childNodes[0];
const firstRadioNode = ReactDOM.findDOMNode(stub).childNodes[1];
expect(firstRadioNode.checked).toBe(false);
dispatchEventOnNode(buttonNode, 'click');
expect(firstRadioNode.checked).toBe(true);
});
it('should control radio buttons if the tree updates during render', () => {
const sharedParent = container;
const container1 = document.createElement('div');
const container2 = document.createElement('div');
sharedParent.appendChild(container1);
let aNode;
let bNode;
class ComponentA extends React.Component {
state = {changed: false};
handleChange = () => {
this.setState({
changed: true,
});
};
componentDidUpdate() {
sharedParent.appendChild(container2);
}
componentDidMount() {
ReactDOM.render(<ComponentB />, container2);
}
render() {
return (
<div>
<input
ref={n => (aNode = n)}
type="radio"
name="fruit"
checked={false}
onChange={this.handleChange}
/>
A
</div>
);
}
}
class ComponentB extends React.Component {
render() {
return (
<div>
<input
ref={n => (bNode = n)}
type="radio"
name="fruit"
checked={true}
onChange={emptyFunction}
/>
B
</div>
);
}
}
ReactDOM.render(<ComponentA />, container1);
expect(aNode.checked).toBe(false);
expect(bNode.checked).toBe(true);
setUntrackedChecked.call(aNode, true);
setUntrackedChecked.call(bNode, false);
dispatchEventOnNode(aNode, 'click');
expect(aNode.checked).toBe(false);
expect(bNode.checked).toBe(true);
});
it('should warn with value and no onChange handler and readOnly specified', () => {
ReactDOM.render(
<input type="text" value="zoink" readOnly={true} />,
container,
);
ReactDOM.unmountComponentAtNode(container);
expect(() =>
ReactDOM.render(
<input type="text" value="zoink" readOnly={false} />,
container,
),
).toErrorDev(
'Warning: You provided a `value` prop to a form ' +
'field without an `onChange` handler. This will render a read-only ' +
'field. If the field should be mutable use `defaultValue`. ' +
'Otherwise, set either `onChange` or `readOnly`.\n' +
' in input (at **)',
);
});
it('should have a this value of undefined if bind is not used', () => {
expect.assertions(1);
const unboundInputOnChange = function () {
expect(this).toBe(undefined);
};
const stub = <input type="text" onChange={unboundInputOnChange} />;
const node = ReactDOM.render(stub, container);
setUntrackedValue.call(node, 'giraffe');
dispatchEventOnNode(node, 'input');
});
it('should update defaultValue to empty string', () => {
ReactDOM.render(<input type="text" defaultValue={'foo'} />, container);
ReactDOM.render(<input type="text" defaultValue={''} />, container);
expect(container.firstChild.defaultValue).toBe('');
});
it('should warn if value is null', () => {
expect(() =>
ReactDOM.render(<input type="text" value={null} />, container),
).toErrorDev(
'`value` prop on `input` should not be null. ' +
'Consider using an empty string to clear the component or `undefined` ' +
'for uncontrolled components.',
);
ReactDOM.unmountComponentAtNode(container);
ReactDOM.render(<input type="text" value={null} />, container);
});
it('should warn if checked and defaultChecked props are specified', () => {
expect(() =>
ReactDOM.render(
<input
type="radio"
checked={true}
defaultChecked={true}
readOnly={true}
/>,
container,
),
).toErrorDev(
'A component contains an input of type radio with both checked and defaultChecked props. ' +
'Input elements must be either controlled or uncontrolled ' +
'(specify either the checked prop, or the defaultChecked prop, but not ' +
'both). Decide between using a controlled or uncontrolled input ' +
'element and remove one of these props. More info: ' +
'https://reactjs.org/link/controlled-components',
);
ReactDOM.unmountComponentAtNode(container);
ReactDOM.render(
<input
type="radio"
checked={true}
defaultChecked={true}
readOnly={true}
/>,
container,
);
});
it('should warn if value and defaultValue props are specified', () => {
expect(() =>
ReactDOM.render(
<input type="text" value="foo" defaultValue="bar" readOnly={true} />,
container,
),
).toErrorDev(
'A component contains an input of type text with both value and defaultValue props. ' +
'Input elements must be either controlled or uncontrolled ' +
'(specify either the value prop, or the defaultValue prop, but not ' +
'both). Decide between using a controlled or uncontrolled input ' +
'element and remove one of these props. More info: ' +
'https://reactjs.org/link/controlled-components',
);
ReactDOM.unmountComponentAtNode(container);
ReactDOM.render(
<input type="text" value="foo" defaultValue="bar" readOnly={true} />,
container,
);
});
it('should warn if controlled input switches to uncontrolled (value is undefined)', () => {
const stub = (
<input type="text" value="controlled" onChange={emptyFunction} />
);
ReactDOM.render(stub, container);
expect(() => ReactDOM.render(<input type="text" />, container)).toErrorDev(
'Warning: A component is changing a controlled input to be uncontrolled. ' +
'This is likely caused by the value changing from a defined to ' +
'undefined, which should not happen. ' +
'Decide between using a controlled or uncontrolled input ' +
'element for the lifetime of the component. More info: https://reactjs.org/link/controlled-components\n' +
' in input (at **)',
);
});
it('should warn if controlled input switches to uncontrolled (value is null)', () => {
const stub = (
<input type="text" value="controlled" onChange={emptyFunction} />
);
ReactDOM.render(stub, container);
expect(() =>
ReactDOM.render(<input type="text" value={null} />, container),
).toErrorDev([
'`value` prop on `input` should not be null. ' +
'Consider using an empty string to clear the component or `undefined` for uncontrolled components',
'Warning: A component is changing a controlled input to be uncontrolled. ' +
'This is likely caused by the value changing from a defined to ' +
'undefined, which should not happen. ' +
'Decide between using a controlled or uncontrolled input ' +
'element for the lifetime of the component. More info: https://reactjs.org/link/controlled-components\n' +
' in input (at **)',
]);
});
it('should warn if controlled input switches to uncontrolled with defaultValue', () => {
const stub = (
<input type="text" value="controlled" onChange={emptyFunction} />
);
ReactDOM.render(stub, container);
expect(() =>
ReactDOM.render(
<input type="text" defaultValue="uncontrolled" />,
container,
),
).toErrorDev(
'Warning: A component is changing a controlled input to be uncontrolled. ' +
'This is likely caused by the value changing from a defined to ' +
'undefined, which should not happen. ' +
'Decide between using a controlled or uncontrolled input ' +
'element for the lifetime of the component. More info: https://reactjs.org/link/controlled-components\n' +
' in input (at **)',
);
});
it('should warn if uncontrolled input (value is undefined) switches to controlled', () => {
const stub = <input type="text" />;
ReactDOM.render(stub, container);
expect(() =>
ReactDOM.render(<input type="text" value="controlled" />, container),
).toErrorDev(
'Warning: A component is changing an uncontrolled input to be controlled. ' +
'This is likely caused by the value changing from undefined to ' +
'a defined value, which should not happen. ' +
'Decide between using a controlled or uncontrolled input ' +
'element for the lifetime of the component. More info: https://reactjs.org/link/controlled-components\n' +
' in input (at **)',
);
});
it('should warn if uncontrolled input (value is null) switches to controlled', () => {
const stub = <input type="text" value={null} />;
expect(() => ReactDOM.render(stub, container)).toErrorDev(
'`value` prop on `input` should not be null. ' +
'Consider using an empty string to clear the component or `undefined` for uncontrolled components.',
);
expect(() =>
ReactDOM.render(<input type="text" value="controlled" />, container),
).toErrorDev(
'Warning: A component is changing an uncontrolled input to be controlled. ' +
'This is likely caused by the value changing from undefined to ' +
'a defined value, which should not happen. ' +
'Decide between using a controlled or uncontrolled input ' +
'element for the lifetime of the component. More info: https://reactjs.org/link/controlled-components\n' +
' in input (at **)',
);
});
it('should warn if controlled checkbox switches to uncontrolled (checked is undefined)', () => {
const stub = (
<input type="checkbox" checked={true} onChange={emptyFunction} />
);
ReactDOM.render(stub, container);
expect(() =>
ReactDOM.render(<input type="checkbox" />, container),
).toErrorDev(
'Warning: A component is changing a controlled input to be uncontrolled. ' +
'This is likely caused by the value changing from a defined to ' +
'undefined, which should not happen. ' +
'Decide between using a controlled or uncontrolled input ' +
'element for the lifetime of the component. More info: https://reactjs.org/link/controlled-components\n' +
' in input (at **)',
);
});
it('should warn if controlled checkbox switches to uncontrolled (checked is null)', () => {
const stub = (
<input type="checkbox" checked={true} onChange={emptyFunction} />
);
ReactDOM.render(stub, container);
expect(() =>
ReactDOM.render(<input type="checkbox" checked={null} />, container),
).toErrorDev(
'Warning: A component is changing a controlled input to be uncontrolled. ' +
'This is likely caused by the value changing from a defined to ' +
'undefined, which should not happen. ' +
'Decide between using a controlled or uncontrolled input ' +
'element for the lifetime of the component. More info: https://reactjs.org/link/controlled-components\n' +
' in input (at **)',
);
});
it('should warn if controlled checkbox switches to uncontrolled with defaultChecked', () => {
const stub = (
<input type="checkbox" checked={true} onChange={emptyFunction} />
);
ReactDOM.render(stub, container);
expect(() =>
ReactDOM.render(
<input type="checkbox" defaultChecked={true} />,
container,
),
).toErrorDev(
'Warning: A component is changing a controlled input to be uncontrolled. ' +
'This is likely caused by the value changing from a defined to ' +
'undefined, which should not happen. ' +
'Decide between using a controlled or uncontrolled input ' +
'element for the lifetime of the component. More info: https://reactjs.org/link/controlled-components\n' +
' in input (at **)',
);
});
it('should warn if uncontrolled checkbox (checked is undefined) switches to controlled', () => {
const stub = <input type="checkbox" />;
ReactDOM.render(stub, container);
expect(() =>
ReactDOM.render(<input type="checkbox" checked={true} />, container),
).toErrorDev(
'Warning: A component is changing an uncontrolled input to be controlled. ' +
'This is likely caused by the value changing from undefined to ' +
'a defined value, which should not happen. ' +
'Decide between using a controlled or uncontrolled input ' +
'element for the lifetime of the component. More info: https://reactjs.org/link/controlled-components\n' +
' in input (at **)',
);
});
it('should warn if uncontrolled checkbox (checked is null) switches to controlled', () => {
const stub = <input type="checkbox" checked={null} />;
ReactDOM.render(stub, container);
expect(() =>
ReactDOM.render(<input type="checkbox" checked={true} />, container),
).toErrorDev(
'Warning: A component is changing an uncontrolled input to be controlled. ' +
'This is likely caused by the value changing from undefined to ' +
'a defined value, which should not happen. ' +
'Decide between using a controlled or uncontrolled input ' +
'element for the lifetime of the component. More info: https://reactjs.org/link/controlled-components\n' +
' in input (at **)',
);
});
it('should warn if controlled radio switches to uncontrolled (checked is undefined)', () => {
const stub = <input type="radio" checked={true} onChange={emptyFunction} />;
ReactDOM.render(stub, container);
expect(() => ReactDOM.render(<input type="radio" />, container)).toErrorDev(
'Warning: A component is changing a controlled input to be uncontrolled. ' +
'This is likely caused by the value changing from a defined to ' +
'undefined, which should not happen. ' +
'Decide between using a controlled or uncontrolled input ' +
'element for the lifetime of the component. More info: https://reactjs.org/link/controlled-components\n' +
' in input (at **)',
);
});
it('should warn if controlled radio switches to uncontrolled (checked is null)', () => {
const stub = <input type="radio" checked={true} onChange={emptyFunction} />;
ReactDOM.render(stub, container);
expect(() =>
ReactDOM.render(<input type="radio" checked={null} />, container),
).toErrorDev(
'Warning: A component is changing a controlled input to be uncontrolled. ' +
'This is likely caused by the value changing from a defined to ' +
'undefined, which should not happen. ' +
'Decide between using a controlled or uncontrolled input ' +
'element for the lifetime of the component. More info: https://reactjs.org/link/controlled-components\n' +
' in input (at **)',
);
});
it('should warn if controlled radio switches to uncontrolled with defaultChecked', () => {
const stub = <input type="radio" checked={true} onChange={emptyFunction} />;
ReactDOM.render(stub, container);
expect(() =>
ReactDOM.render(<input type="radio" defaultChecked={true} />, container),
).toErrorDev(
'Warning: A component is changing a controlled input to be uncontrolled. ' +
'This is likely caused by the value changing from a defined to ' +
'undefined, which should not happen. ' +
'Decide between using a controlled or uncontrolled input ' +
'element for the lifetime of the component. More info: https://reactjs.org/link/controlled-components\n' +
' in input (at **)',
);
});
it('should warn if uncontrolled radio (checked is undefined) switches to controlled', () => {
const stub = <input type="radio" />;
ReactDOM.render(stub, container);
expect(() =>
ReactDOM.render(<input type="radio" checked={true} />, container),
).toErrorDev(
'Warning: A component is changing an uncontrolled input to be controlled. ' +
'This is likely caused by the value changing from undefined to ' +
'a defined value, which should not happen. ' +
'Decide between using a controlled or uncontrolled input ' +
'element for the lifetime of the component. More info: https://reactjs.org/link/controlled-components\n' +
' in input (at **)',
);
});
it('should warn if uncontrolled radio (checked is null) switches to controlled', () => {
const stub = <input type="radio" checked={null} />;
ReactDOM.render(stub, container);
expect(() =>
ReactDOM.render(<input type="radio" checked={true} />, container),
).toErrorDev(
'Warning: A component is changing an uncontrolled input to be controlled. ' +
'This is likely caused by the value changing from undefined to ' +
'a defined value, which should not happen. ' +
'Decide between using a controlled or uncontrolled input ' +
'element for the lifetime of the component. More info: https://reactjs.org/link/controlled-components\n' +
' in input (at **)',
);
});
it('should not warn if radio value changes but never becomes controlled', () => {
ReactDOM.render(<input type="radio" value="value" />, container);
ReactDOM.render(<input type="radio" />, container);
ReactDOM.render(
<input type="radio" value="value" defaultChecked={true} />,
container,
);
ReactDOM.render(
<input type="radio" value="value" onChange={() => null} />,
container,
);
ReactDOM.render(<input type="radio" />, container);
});
it('should not warn if radio value changes but never becomes uncontrolled', () => {
ReactDOM.render(
<input type="radio" checked={false} onChange={() => null} />,
container,
);
ReactDOM.render(
<input
type="radio"
value="value"
defaultChecked={true}
checked={false}
onChange={() => null}
/>,
container,
);
});
it('should warn if radio checked false changes to become uncontrolled', () => {
ReactDOM.render(
<input
type="radio"
value="value"
checked={false}
onChange={() => null}
/>,
container,
);
expect(() =>
ReactDOM.render(<input type="radio" value="value" />, container),
).toErrorDev(
'Warning: A component is changing a controlled input to be uncontrolled. ' +
'This is likely caused by the value changing from a defined to ' +
'undefined, which should not happen. ' +
'Decide between using a controlled or uncontrolled input ' +
'element for the lifetime of the component. More info: https://reactjs.org/link/controlled-components\n' +
' in input (at **)',
);
});
it('sets type, step, min, max before value always', () => {
const log = [];
const originalCreateElement = document.createElement;
spyOnDevAndProd(document, 'createElement').mockImplementation(function (
type,
) {
const el = originalCreateElement.apply(this, arguments);
let value = '';
if (type === 'input') {
Object.defineProperty(el, 'value', {
get: function () {
return value;
},
set: function (val) {
value = String(val);
log.push('set property value');
},
});
spyOnDevAndProd(el, 'setAttribute').mockImplementation(function (name) {
log.push('set attribute ' + name);
});
}
return el;
});
ReactDOM.render(
<input
value="0"
onChange={() => {}}
type="range"
min="0"
max="100"
step="1"
/>,
container,
);
expect(log).toEqual([
'set attribute type',
'set attribute min',
'set attribute max',
'set attribute step',
'set property value',
]);
});
it('sets value properly with type coming later in props', () => {
const input = ReactDOM.render(<input value="hi" type="radio" />, container);
expect(input.value).toBe('hi');
});
it('does not raise a validation warning when it switches types', () => {
class Input extends React.Component {
state = {type: 'number', value: 1000};
render() {
const {value, type} = this.state;
return <input onChange={() => {}} type={type} value={value} />;
}
}
const input = ReactDOM.render(<Input />, container);
const node = ReactDOM.findDOMNode(input);
input.setState({type: 'text', value: 'Test'});
expect(node.value).toEqual('Test');
});
it('resets value of date/time input to fix bugs in iOS Safari', () => {
function strify(x) {
return JSON.stringify(x, null, 2);
}
const log = [];
const originalCreateElement = document.createElement;
spyOnDevAndProd(document, 'createElement').mockImplementation(function (
type,
) {
const el = originalCreateElement.apply(this, arguments);
const getDefaultValue = Object.getOwnPropertyDescriptor(
HTMLInputElement.prototype,
'defaultValue',
).get;
const setDefaultValue = Object.getOwnPropertyDescriptor(
HTMLInputElement.prototype,
'defaultValue',
).set;
const getValue = Object.getOwnPropertyDescriptor(
HTMLInputElement.prototype,
'value',
).get;
const setValue = Object.getOwnPropertyDescriptor(
HTMLInputElement.prototype,
'value',
).set;
if (type === 'input') {
Object.defineProperty(el, 'defaultValue', {
get: function () {
return getDefaultValue.call(this);
},
set: function (val) {
log.push(`node.defaultValue = ${strify(val)}`);
setDefaultValue.call(this, val);
},
});
Object.defineProperty(el, 'value', {
get: function () {
return getValue.call(this);
},
set: function (val) {
log.push(`node.value = ${strify(val)}`);
setValue.call(this, val);
},
});
spyOnDevAndProd(el, 'setAttribute').mockImplementation(function (
name,
val,
) {
log.push(`node.setAttribute(${strify(name)}, ${strify(val)})`);
});
}
return el;
});
ReactDOM.render(<input type="date" defaultValue="1980-01-01" />, container);
if (disableInputAttributeSyncing) {
expect(log).toEqual([
'node.setAttribute("type", "date")',
'node.defaultValue = "1980-01-01"',
]);
} else {
expect(log).toEqual([
'node.setAttribute("type", "date")',
'node.value = "1980-01-01"',
'node.defaultValue = "1980-01-01"',
]);
}
});
describe('assigning the value attribute on controlled inputs', function () {
function getTestInput() {
return class extends React.Component {
state = {
value: this.props.value == null ? '' : this.props.value,
};
onChange = event => {
this.setState({value: event.target.value});
};
render() {
const type = this.props.type;
const value = this.state.value;
return <input type={type} value={value} onChange={this.onChange} />;
}
};
}
it('always sets the attribute when values change on text inputs', function () {
const Input = getTestInput();
const stub = ReactDOM.render(<Input type="text" />, container);
const node = ReactDOM.findDOMNode(stub);
setUntrackedValue.call(node, '2');
dispatchEventOnNode(node, 'input');
if (disableInputAttributeSyncing) {
expect(node.hasAttribute('value')).toBe(false);
} else {
expect(node.getAttribute('value')).toBe('2');
}
});
it('does not set the value attribute on number inputs if focused', () => {
const Input = getTestInput();
const stub = ReactDOM.render(
<Input type="number" value="1" />,
container,
);
const node = ReactDOM.findDOMNode(stub);
node.focus();
setUntrackedValue.call(node, '2');
dispatchEventOnNode(node, 'input');
if (disableInputAttributeSyncing) {
expect(node.hasAttribute('value')).toBe(false);
} else {
expect(node.getAttribute('value')).toBe('1');
}
});
it('sets the value attribute on number inputs on blur', () => {
const Input = getTestInput();
const stub = ReactDOM.render(
<Input type="number" value="1" />,
container,
);
const node = ReactDOM.findDOMNode(stub);
node.focus();
setUntrackedValue.call(node, '2');
dispatchEventOnNode(node, 'input');
node.blur();
if (disableInputAttributeSyncing) {
expect(node.value).toBe('2');
expect(node.hasAttribute('value')).toBe(false);
} else {
expect(node.value).toBe('2');
expect(node.getAttribute('value')).toBe('2');
}
});
it('an uncontrolled number input will not update the value attribute on blur', () => {
const node = ReactDOM.render(
<input type="number" defaultValue="1" />,
container,
);
node.focus();
setUntrackedValue.call(node, 4);
dispatchEventOnNode(node, 'input');
node.blur();
expect(node.getAttribute('value')).toBe('1');
});
it('an uncontrolled text input will not update the value attribute on blur', () => {
const node = ReactDOM.render(
<input type="text" defaultValue="1" />,
container,
);
node.focus();
setUntrackedValue.call(node, 4);
dispatchEventOnNode(node, 'input');
node.blur();
expect(node.getAttribute('value')).toBe('1');
});
});
describe('setting a controlled input to undefined', () => {
let input;
function renderInputWithStringThenWithUndefined() {
let setValueToUndefined;
class Input extends React.Component {
constructor() {
super();
setValueToUndefined = () => this.setState({value: undefined});
}
state = {value: 'first'};
render() {
return (
<input
onChange={e => this.setState({value: e.target.value})}
value={this.state.value}
/>
);
}
}
const stub = ReactDOM.render(<Input />, container);
input = ReactDOM.findDOMNode(stub);
setUntrackedValue.call(input, 'latest');
dispatchEventOnNode(input, 'input');
setValueToUndefined();
}
it('reverts the value attribute to the initial value', () => {
expect(renderInputWithStringThenWithUndefined).toErrorDev(
'A component is changing a controlled input to be uncontrolled.',
);
if (disableInputAttributeSyncing) {
expect(input.getAttribute('value')).toBe(null);
} else {
expect(input.getAttribute('value')).toBe('first');
}
});
it('preserves the value property', () => {
expect(renderInputWithStringThenWithUndefined).toErrorDev(
'A component is changing a controlled input to be uncontrolled.',
);
expect(input.value).toBe('latest');
});
});
describe('setting a controlled input to null', () => {
let input;
function renderInputWithStringThenWithNull() {
let setValueToNull;
class Input extends React.Component {
constructor() {
super();
setValueToNull = () => this.setState({value: null});
}
state = {value: 'first'};
render() {
return (
<input
onChange={e => this.setState({value: e.target.value})}
value={this.state.value}
/>
);
}
}
const stub = ReactDOM.render(<Input />, container);
input = ReactDOM.findDOMNode(stub);
setUntrackedValue.call(input, 'latest');
dispatchEventOnNode(input, 'input');
setValueToNull();
}
it('reverts the value attribute to the initial value', () => {
expect(renderInputWithStringThenWithNull).toErrorDev([
'`value` prop on `input` should not be null. ' +
'Consider using an empty string to clear the component ' +
'or `undefined` for uncontrolled components.',
'A component is changing a controlled input to be uncontrolled.',
]);
if (disableInputAttributeSyncing) {
expect(input.hasAttribute('value')).toBe(false);
} else {
expect(input.getAttribute('value')).toBe('first');
}
});
it('preserves the value property', () => {
expect(renderInputWithStringThenWithNull).toErrorDev([
'`value` prop on `input` should not be null. ' +
'Consider using an empty string to clear the component ' +
'or `undefined` for uncontrolled components.',
'A component is changing a controlled input to be uncontrolled.',
]);
expect(input.value).toBe('latest');
});
});
describe('When given a Symbol value', function () {
it('treats initial Symbol value as an empty string', function () {
expect(() =>
ReactDOM.render(
<input value={Symbol('foobar')} onChange={() => {}} />,
container,
),
).toErrorDev('Invalid value for prop `value`');
const node = container.firstChild;
expect(node.value).toBe('');
if (disableInputAttributeSyncing) {
expect(node.hasAttribute('value')).toBe(false);
} else {
expect(node.getAttribute('value')).toBe('');
}
});
it('treats updated Symbol value as an empty string', function () {
ReactDOM.render(<input value="foo" onChange={() => {}} />, container);
expect(() =>
ReactDOM.render(
<input value={Symbol('foobar')} onChange={() => {}} />,
container,
),
).toErrorDev('Invalid value for prop `value`');
const node = container.firstChild;
expect(node.value).toBe('');
if (disableInputAttributeSyncing) {
expect(node.hasAttribute('value')).toBe(false);
} else {
expect(node.getAttribute('value')).toBe('');
}
});
it('treats initial Symbol defaultValue as an empty string', function () {
ReactDOM.render(<input defaultValue={Symbol('foobar')} />, container);
const node = container.firstChild;
expect(node.value).toBe('');
expect(node.getAttribute('value')).toBe('');
});
it('treats updated Symbol defaultValue as an empty string', function () {
ReactDOM.render(<input defaultValue="foo" />, container);
ReactDOM.render(<input defaultValue={Symbol('foobar')} />, container);
const node = container.firstChild;
if (disableInputAttributeSyncing) {
expect(node.value).toBe('');
} else {
expect(node.value).toBe('foo');
}
expect(node.getAttribute('value')).toBe('');
});
});
describe('When given a function value', function () {
it('treats initial function value as an empty string', function () {
expect(() =>
ReactDOM.render(
<input value={() => {}} onChange={() => {}} />,
container,
),
).toErrorDev('Invalid value for prop `value`');
const node = container.firstChild;
expect(node.value).toBe('');
if (disableInputAttributeSyncing) {
expect(node.hasAttribute('value')).toBe(false);
} else {
expect(node.getAttribute('value')).toBe('');
}
});
it('treats updated function value as an empty string', function () {
ReactDOM.render(<input value="foo" onChange={() => {}} />, container);
expect(() =>
ReactDOM.render(
<input value={() => {}} onChange={() => {}} />,
container,
),
).toErrorDev('Invalid value for prop `value`');
const node = container.firstChild;
expect(node.value).toBe('');
if (disableInputAttributeSyncing) {
expect(node.hasAttribute('value')).toBe(false);
} else {
expect(node.getAttribute('value')).toBe('');
}
});
it('treats initial function defaultValue as an empty string', function () {
ReactDOM.render(<input defaultValue={() => {}} />, container);
const node = container.firstChild;
expect(node.value).toBe('');
expect(node.getAttribute('value')).toBe('');
});
it('treats updated function defaultValue as an empty string', function () {
ReactDOM.render(<input defaultValue="foo" />, container);
ReactDOM.render(<input defaultValue={() => {}} />, container);
const node = container.firstChild;
if (disableInputAttributeSyncing) {
expect(node.value).toBe('');
expect(node.getAttribute('value')).toBe('');
} else {
expect(node.value).toBe('foo');
expect(node.getAttribute('value')).toBe('');
}
});
});
describe('checked inputs without a value property', function () {
it('does not add "on" in absence of value on a checkbox', function () {
ReactDOM.render(
<input type="checkbox" defaultChecked={true} />,
container,
);
const node = container.firstChild;
expect(node.value).toBe('on');
expect(node.hasAttribute('value')).toBe(false);
});
it('does not add "on" in absence of value on a radio', function () {
ReactDOM.render(<input type="radio" defaultChecked={true} />, container);
const node = container.firstChild;
expect(node.value).toBe('on');
expect(node.hasAttribute('value')).toBe(false);
});
});
});