import { CompilerError, Effect, ErrorSeverity } from "..";
import {
GeneratedSource,
Identifier,
IdentifierId,
Instruction,
InstructionValue,
ManualMemoDependency,
Place,
ReactiveFunction,
ReactiveInstruction,
ReactiveScopeBlock,
ReactiveScopeDependency,
ReactiveValue,
ScopeId,
SourceLocation,
} from "../HIR";
import { printManualMemoDependency } from "../HIR/PrintHIR";
import { eachInstructionValueOperand } from "../HIR/visitors";
import { collectMaybeMemoDependencies } from "../Inference/DropManualMemoization";
import { isMutable } from "../ReactiveScopes/InferReactiveScopeVariables";
import {
ReactiveFunctionVisitor,
visitReactiveFunction,
} from "../ReactiveScopes/visitors";
export function validatePreservedManualMemoization(fn: ReactiveFunction): void {
const state = {
errors: new CompilerError(),
manualMemoState: null,
};
visitReactiveFunction(fn, new Visitor(), state);
if (state.errors.hasErrors()) {
throw state.errors;
}
}
const DEBUG = false;
type ManualMemoBlockState = {
loc: SourceLocation;
decls: Set<IdentifierId>;
depsFromSource: Array<ManualMemoDependency> | null;
manualMemoId: number;
};
type VisitorState = {
errors: CompilerError;
manualMemoState: ManualMemoBlockState | null;
};
function prettyPrintScopeDependency(val: ReactiveScopeDependency): string {
let rootStr;
if (val.identifier.name?.kind === "named") {
rootStr = val.identifier.name.value;
} else {
rootStr = "[unnamed]";
}
return `${rootStr}${val.path.length > 0 ? "." : ""}${val.path.join(".")}`;
}
enum CompareDependencyResult {
Ok = 0,
RootDifference = 1,
PathDifference = 2,
Subpath = 3,
RefAccessDifference = 4,
}
function merge(
a: CompareDependencyResult,
b: CompareDependencyResult
): CompareDependencyResult {
return Math.max(a, b);
}
function getCompareDependencyResultDescription(
result: CompareDependencyResult
): string {
switch (result) {
case CompareDependencyResult.Ok:
return "dependencies equal";
case CompareDependencyResult.RootDifference:
case CompareDependencyResult.PathDifference:
return "inferred different dependency than source";
case CompareDependencyResult.RefAccessDifference:
return "differences in ref.current access";
case CompareDependencyResult.Subpath:
return "inferred less specific property than source";
}
}
function compareDeps(
inferred: ManualMemoDependency,
source: ManualMemoDependency
): CompareDependencyResult {
const rootsEqual =
(inferred.root.kind === "Global" &&
source.root.kind === "Global" &&
inferred.root.identifierName === source.root.identifierName) ||
(inferred.root.kind === "NamedLocal" &&
source.root.kind === "NamedLocal" &&
inferred.root.value.identifier.id === source.root.value.identifier.id);
if (!rootsEqual) {
return CompareDependencyResult.RootDifference;
}
let isSubpath = true;
for (let i = 0; i < Math.min(inferred.path.length, source.path.length); i++) {
if (inferred.path[i] !== source.path[i]) {
isSubpath = false;
break;
}
}
if (
isSubpath &&
(source.path.length === inferred.path.length ||
(inferred.path.length >= source.path.length &&
!inferred.path.includes("current")))
) {
return CompareDependencyResult.Ok;
} else {
if (isSubpath) {
if (
source.path.includes("current") ||
inferred.path.includes("current")
) {
return CompareDependencyResult.RefAccessDifference;
} else {
return CompareDependencyResult.Subpath;
}
} else {
return CompareDependencyResult.PathDifference;
}
}
}
function validateInferredDep(
dep: ReactiveScopeDependency,
temporaries: Map<IdentifierId, ManualMemoDependency>,
declsWithinMemoBlock: Set<IdentifierId>,
validDepsInMemoBlock: Array<ManualMemoDependency>,
errorState: CompilerError,
memoLocation: SourceLocation
): void {
let normalizedDep: ManualMemoDependency;
const maybeNormalizedRoot = temporaries.get(dep.identifier.id);
if (maybeNormalizedRoot != null) {
normalizedDep = {
root: maybeNormalizedRoot.root,
path: [...maybeNormalizedRoot.path, ...dep.path],
};
} else {
CompilerError.invariant(dep.identifier.name?.kind === "named", {
reason:
"ValidatePreservedManualMemoization: expected scope dependency to be named",
loc: GeneratedSource,
suggestions: null,
});
normalizedDep = {
root: {
kind: "NamedLocal",
value: {
kind: "Identifier",
identifier: dep.identifier,
loc: GeneratedSource,
effect: Effect.Read,
reactive: false,
},
},
path: [...dep.path],
};
}
for (const decl of declsWithinMemoBlock) {
if (
normalizedDep.root.kind === "NamedLocal" &&
decl === normalizedDep.root.value.identifier.id
) {
return;
}
}
let errorDiagnostic: CompareDependencyResult | null = null;
for (const originalDep of validDepsInMemoBlock) {
const compareResult = compareDeps(normalizedDep, originalDep);
if (compareResult === CompareDependencyResult.Ok) {
return;
} else {
errorDiagnostic = merge(errorDiagnostic ?? compareResult, compareResult);
}
}
errorState.push({
severity: ErrorSeverity.CannotPreserveMemoization,
reason:
"React Compiler has skipped optimizing this component because the existing manual memoization could not be preserved. The inferred dependencies did not match the manually specified dependencies, which could cause the value to change more or less frequently than expected",
description: DEBUG
? `The inferred dependency was \`${prettyPrintScopeDependency(
dep
)}\`, but the source dependencies were [${validDepsInMemoBlock
.map((dep) => printManualMemoDependency(dep, true))
.join(", ")}]. Detail: ${
errorDiagnostic
? getCompareDependencyResultDescription(errorDiagnostic)
: "none"
}`
: null,
loc: memoLocation,
suggestions: null,
});
}
class Visitor extends ReactiveFunctionVisitor<VisitorState> {
scopes: Set<ScopeId> = new Set();
scopeMapping = new Map();
temporaries: Map<IdentifierId, ManualMemoDependency> = new Map();
collectMaybeMemoDependencies(
value: ReactiveValue,
state: VisitorState
): ManualMemoDependency | null {
switch (value.kind) {
case "SequenceExpression": {
for (const instr of value.instructions) {
this.visitInstruction(instr, state);
}
const result = this.collectMaybeMemoDependencies(value.value, state);
return result;
}
case "OptionalExpression": {
return this.collectMaybeMemoDependencies(value.value, state);
}
case "ReactiveFunctionValue":
case "ConditionalExpression":
case "LogicalExpression": {
return null;
}
default: {
const dep = collectMaybeMemoDependencies(value, this.temporaries);
if (value.kind === "StoreLocal" || value.kind === "StoreContext") {
const storeTarget = value.lvalue.place;
state.manualMemoState?.decls.add(storeTarget.identifier.id);
if (storeTarget.identifier.name?.kind === "named" && dep == null) {
const dep: ManualMemoDependency = {
root: {
kind: "NamedLocal",
value: storeTarget,
},
path: [],
};
this.temporaries.set(storeTarget.identifier.id, dep);
return dep;
}
}
return dep;
}
}
}
recordTemporaries(instr: ReactiveInstruction, state: VisitorState): void {
const temporaries = this.temporaries;
const { value } = instr;
const lvalId = instr.lvalue?.identifier.id;
if (lvalId != null && temporaries.has(lvalId)) {
return;
}
const isNamedLocal =
lvalId != null && instr.lvalue?.identifier.name?.kind === "named";
if (isNamedLocal && state.manualMemoState != null) {
state.manualMemoState.decls.add(lvalId);
}
const maybeDep = this.collectMaybeMemoDependencies(value, state);
if (lvalId != null) {
if (maybeDep != null) {
temporaries.set(lvalId, maybeDep);
} else if (isNamedLocal) {
temporaries.set(lvalId, {
root: {
kind: "NamedLocal",
value: { ...(instr.lvalue as Place) },
},
path: [],
});
}
}
}
override visitScope(
scopeBlock: ReactiveScopeBlock,
state: VisitorState
): void {
this.traverseScope(scopeBlock, state);
if (
state.manualMemoState != null &&
state.manualMemoState.depsFromSource != null
) {
for (const dep of scopeBlock.scope.dependencies) {
validateInferredDep(
dep,
this.temporaries,
state.manualMemoState.decls,
state.manualMemoState.depsFromSource,
state.errors,
state.manualMemoState.loc
);
}
}
let areDependenciesMemoized = true;
for (const dep of scopeBlock.scope.dependencies) {
if (isUnmemoized(dep.identifier, this.scopes)) {
areDependenciesMemoized = false;
break;
}
}
if (areDependenciesMemoized) {
this.scopes.add(scopeBlock.scope.id);
for (const id of scopeBlock.scope.merged) {
this.scopes.add(id);
}
}
}
override visitInstruction(
instruction: ReactiveInstruction,
state: VisitorState
): void {
this.traverseInstruction(instruction, state);
this.recordTemporaries(instruction, state);
if (instruction.value.kind === "StartMemoize") {
let depsFromSource: Array<ManualMemoDependency> | null = null;
if (instruction.value.deps != null) {
depsFromSource = instruction.value.deps;
}
CompilerError.invariant(state.manualMemoState == null, {
reason: "Unexpected nested StartMemoize instructions",
description: `Bad manual memoization ids: ${state.manualMemoState?.manualMemoId}, ${instruction.value.manualMemoId}`,
loc: instruction.value.loc,
suggestions: null,
});
state.manualMemoState = {
loc: instruction.loc,
decls: new Set(),
depsFromSource,
manualMemoId: instruction.value.manualMemoId,
};
}
if (instruction.value.kind === "FinishMemoize") {
CompilerError.invariant(
state.manualMemoState != null &&
state.manualMemoState.manualMemoId === instruction.value.manualMemoId,
{
reason: "Unexpected mismatch between StartMemoize and FinishMemoize",
description: `Encountered StartMemoize id=${state.manualMemoState?.manualMemoId} followed by FinishMemoize id=${instruction.value.manualMemoId}`,
loc: instruction.value.loc,
suggestions: null,
}
);
state.manualMemoState = null;
}
const isDep = instruction.value.kind === "StartMemoize";
const isDecl =
instruction.value.kind === "FinishMemoize" && !instruction.value.pruned;
if (isDep || isDecl) {
for (const value of eachInstructionValueOperand(
instruction.value as InstructionValue
)) {
if (
isMutable(instruction as Instruction, value) ||
(isDecl && isUnmemoized(value.identifier, this.scopes))
) {
state.errors.push({
reason:
"React Compiler has skipped optimizing this component because the existing manual memoization could not be preserved. This value may be mutated later, which could cause the value to change unexpectedly",
description: null,
severity: ErrorSeverity.CannotPreserveMemoization,
loc: typeof instruction.loc !== "symbol" ? instruction.loc : null,
suggestions: null,
});
}
}
}
}
}
function isUnmemoized(operand: Identifier, scopes: Set<ScopeId>): boolean {
return operand.scope != null && !scopes.has(operand.scope.id);
}